Fix wrong Gtk.Widget.get_ancestor signature#217
Merged
lovetox merged 4 commits intopygobject:masterfrom Jun 16, 2025
really-not-lavacat:gtk-get-ancestor-generic
Merged
Fix wrong Gtk.Widget.get_ancestor signature#217lovetox merged 4 commits intopygobject:masterfrom really-not-lavacat:gtk-get-ancestor-generic
Gtk.Widget.get_ancestor signature#217lovetox merged 4 commits intopygobject:masterfrom
really-not-lavacat:gtk-get-ancestor-generic
Conversation
Collaborator
|
i think you need to fix your branch, this is not mergable |
Contributor
Author
|
Somehow I resolved conflicts, seems to be mergable now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Sorry to open new PR after my previous one was merged, but I found out that my previous PR was slightly incorrect: for code analyzers, it looked like
get_ancestoraccepts type and returns type (or accepts instance and returns instance), which resulted in strange error forget_ancestor(Gtk.Button):Now I edited
get_ancestor, so it accepts type and returns instance (orNone), which is correct.Sorry again